Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of priorityClassName to the helm chart #286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support of priorityClassName to the helm chart #286

wants to merge 1 commit into from

Conversation

mjshariati98
Copy link

The current helm chart doesn't support setting priorityClassName for the operator pods. By this PR, users can set priorityClassName as a helm value to be used by the operator.

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign irbekrm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bmsiegel
Copy link
Contributor

Hi, it looks like this PR needs a rebase.

@jetstack-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wallrj
Copy link
Member

wallrj commented Mar 13, 2024

@mjshariati98 I've been writing some documentation explaining why to set priorityClassName when deploying cert-manager and what the value should be. I am interested to know what priority class name you intend to use for the aws-privateca-issuer in production and why.
Please read and feedback if you have time:

@wallrj wallrj mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes needs-rebase size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mjshariati98 @jetstack-bot @bmsiegel @wallrj @kollabpr